Issue 10399021: test.dart: include _dart2js.status when creating test suites with 'forDirectory'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399021: test.dart: include _dart2js.status when creating test suites with 'forDirectory' (Closed)

Created:
8 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 7 months ago

Reviewers:
Bob Nystrom, ahe, Bill Hesse

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

test.dart: include _dart2js.status when creating test suites with 'forDirectory' this will allow dart2js to split their status files to reduce their conflicts. Committed: https://code.google.com/p/dart/source/detail?r=7663

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -228 lines)			Patch
M	tests/language/language.status	View		1 chunk	+0 lines, -227 lines	0 comments	Download
A	tests/language/language_dart2js.status	View		1 chunk	+230 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! I like that you used _dart2js.status instead of _leg.status. This is an improvement! Cheers, ...

8 years, 7 months ago (2012-05-15 05:55:26 UTC) #2

lgtm

Expand Messages | Collapse Messages