Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10399021: test.dart: include _dart2js.status when creating test suites with 'forDirectory' (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language_dart2js.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 8760b72ec745e74eb94e01f546a5688704aa1109..454061797b635656f79d0335571dc40e21e4e6f5 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -257,7 +257,8 @@ class StandardTestSuite implements TestSuite {
final name = directory.substring(directory.lastIndexOf('/') + 1);
return new StandardTestSuite(configuration,
- name, directory, ['$directory/$name.status'],
+ name, directory,
+ ['$directory/$name.status', '$directory/${name}_dart2js.status'],
(filename) => filename.endsWith('_test.dart'),
recursive: true);
}
@@ -322,6 +323,15 @@ class StandardTestSuite implements TestSuite {
// Read test expectations from status files.
testExpectations = new TestExpectations();
for (var statusFilePath in statusFilePaths) {
+ // [forDirectory] adds name_dart2js.status for all tests suites, use it if
+ // it exists, but otherwise skip it and don't fail.
+ if (statusFilePath.endsWith('_dart2js.status')) {
+ File file = new File('$dartDir/$statusFilePath');
+ if (!file.existsSync()) {
+ filesRead++;
+ continue;
+ }
+ }
ReadTestExpectationsInto(testExpectations,
'$dartDir/$statusFilePath',
configuration,
« no previous file with comments | « tests/language/language_dart2js.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698