Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 10398056: Remove system-provided temporary directory usage from test scripts. (Closed)

Created:
8 years, 7 months ago by Bill Hesse
Modified:
8 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove system-provided temporary directory usage from test scripts. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -79 lines) Patch
M tools/test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tools/test-runtime.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 5 chunks +3 lines, -35 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 7 chunks +8 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
This is all dead code, because StubGenerator tests are gone, and dartc is not running ...
8 years, 7 months ago (2012-05-16 14:56:17 UTC) #1
Bill Hesse
This is all dead code, because StubGenerator tests are gone, and dartc is not running ...
8 years, 7 months ago (2012-05-16 14:59:53 UTC) #2
Emily Fortuna
8 years, 7 months ago (2012-05-16 16:36:04 UTC) #3
lgtm. I just want to make sure -- the temporary html pages and compiled js that
is used for the browser tests doesn't use this code, right? (I didn't think so,
but just wanted to be certain)

Powered by Google App Engine
This is Rietveld 408576698