Remove system-provided temporary directory usage from test scripts.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 840 matching lines @@
  */
 class ProcessQueue {
   int _numProcesses = 0;
   int _activeTestListers = 0;
   int _maxProcesses;
 
   /** The number of tests we allow to actually fail before we stop retrying. */
   int _MAX_FAILED_NO_RETRY = 4;
   bool _verbose;
   bool _listTests;
-  bool _keepGeneratedTests;
   Function _enqueueMoreWork;
   Queue<TestCase> _tests;
   ProgressIndicator _progress;
-  String _temporaryDirectory;
 
   // For dartc/selenium batch processing we keep a list of batch processes.
   Map<String, List<BatchRunnerProcess>> _batchProcesses;
 
   // Cache information about test cases per test suite. For multiple
   // configurations there is no need to repeatedly search the file
   // system, generate tests, and search test files for options.
   Map<String, List<TestInformation>> _testCache;
 
   /**
@@ skipping 13 matching lines @@
 
   /** True if we find that there is already a selenium jar running. */
   bool _seleniumAlreadyRunning = false;
 
   ProcessQueue(int this._maxProcesses,
                String progress,
                Date startTime,
                bool printTiming,
                Function this._enqueueMoreWork,
                [bool verbose = false,
-                bool listTests = false,
-                bool keepGeneratedTests = false])
+                bool listTests = false])
       : _verbose = verbose,
         _listTests = listTests,
-        _keepGeneratedTests = keepGeneratedTests,
         _tests = new Queue<TestCase>(),
         _progress = new ProgressIndicator.fromName(progress,
                                                    startTime,
                                                    printTiming),
         _batchProcesses = new Map<String, List<BatchRunnerProcess>>(),
         _testCache = new Map<String, List<TestInformation>>() {
     if (!_enqueueMoreWork(this)) _progress.allDone();
   }
 
   /**
    * Registers a TestSuite so that all of its tests will be run.
    */
   void addTestSuite(TestSuite testSuite) {
     _activeTestListers++;
-    testSuite.forEachTest(_runTest, _testCache, globalTemporaryDirectory,
-                          _testListerDone);
+    testSuite.forEachTest(_runTest, _testCache, _testListerDone);
   }
 
   void _testListerDone() {
     _activeTestListers--;
     _checkDone();
   }
 
-  String globalTemporaryDirectory() {
-    if (_temporaryDirectory != null) return _temporaryDirectory;
-
-    if (Platform.operatingSystem == 'windows') {
-      throw new Exception(
-          'Test suite requires temporary directory. Not supported on Windows.');
-    }
-    var tempDir = new Directory('').createTempSync();
-    _temporaryDirectory = tempDir.path;
-    return _temporaryDirectory;
-  }
-
   /**
    * Perform any cleanup needed once all tests in a TestSuite have completed
    * and notify our progress indicator that we are done.
    */
   void _cleanupAndMarkDone() {
     if (browserUsed != '' && _seleniumServer != null) {
         _seleniumServer.kill();
     } else {
       _progress.allDone();
     }
   }
 
   void _checkDone() {
     // When there are no more active test listers ask for more work
     // from process queue users.
     if (_activeTestListers == 0 && !_enqueueMoreWork(this)) {
       _progress.allTestsKnown();
       if (_tests.isEmpty() && _numProcesses == 0) {
         _terminateBatchRunners();
-        if (_keepGeneratedTests || _temporaryDirectory == null) {
-          _cleanupAndMarkDone();
-        } else if (!_temporaryDirectory.startsWith('/tmp/') ||
-                   _temporaryDirectory.contains('/../')) {
-          // Let's be extra careful, since rm -rf is so dangerous.
-          print('Temporary directory $_temporaryDirectory unsafe to delete!');
-          _cleanupAndMarkDone();
-        } else {
-          Directory dir = new Directory(_temporaryDirectory);
-          dir.deleteRecursively(() {
-            _cleanupAndMarkDone();
-          });
-          dir.onError = (err) {
-            print('\nDeletion of temp dir $_temporaryDirectory failed: $err');
-          };
-        }
+        _cleanupAndMarkDone();
       }
     }
   }
 
   /**
    * True if we are using a browser + platform combination that needs the
    * Selenium server jar.
    */
   bool get _needsSelenium() => Platform.operatingSystem == 'macos' &&
       browserUsed == 'safari';
@@ skipping 184 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }