Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10392016: Fix issue 2939, revert previous change that accepted null as excpetion objects: (Closed)

Created:
8 years, 7 months ago by srdjan
Modified:
8 years, 7 months ago
Reviewers:
ahe, hausner
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Fix issue 2939, revert previous change that accepted null as excpetion objects: throw null throws NullPointerException as per latest spec. Committed: https://code.google.com/p/dart/source/detail?r=7475

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M runtime/vm/exceptions.cc View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/exception_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/is_object_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 7 months ago (2012-05-09 22:02:18 UTC) #1
hausner
lgtm
8 years, 7 months ago (2012-05-09 22:07:51 UTC) #2
ahe
8 years, 7 months ago (2012-05-10 17:54:35 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698