runtime/vm/exceptions.cc - Issue 10392016: Fix issue 2939, revert previous change that accepted null as excpetion objects:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 10392016: Fix issue 2939, revert previous change that accepted null as excpetion objects: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/exceptions.cc

===================================================================

--- runtime/vm/exceptions.cc (revision 7471)

+++ runtime/vm/exceptions.cc (working copy)

@@ -63,8 +63,13 @@

}

-static void ThrowExceptionHelper(const Instance& exception,

+static void ThrowExceptionHelper(const Instance& incoming_exception,

const Instance& existing_stacktrace) {

+ Instance& exception = Instance::Handle(incoming_exception.raw());

+ if (exception.IsNull()) {

+ GrowableArray<const Object*> arguments;

+ exception ^= Exceptions::Create(Exceptions::kNullPointer, arguments);

+ }

uword handler_pc = 0;

uword handler_sp = 0;

uword handler_fp = 0;

« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »