Add locations to diagnostics.

Add locations to diagnostics.

Committed: https://code.google.com/p/dart/source/detail?r=7660

[kasperl, 2012-05-15 12:09:15]

I guess this will add a bunch of static warnings, right? Essentially all the
places where you added a TODO describing that you need a compiler but do not
have one.

https://chromiumcodereview.appspot.com/10389143/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10389143/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/builder.dart:684: unreachable();
Didn't you remove unreachable()?

[ahe, 2012-05-15 12:09:38]

This is addressing part of http://code.google.com/p/dart/issues/detail?id=3062

[ahe, 2012-05-15 12:28:04]

https://chromiumcodereview.appspot.com/10389143/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10389143/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/builder.dart:684: unreachable();
On 2012/05/15 12:09:16, kasperl wrote:
> Didn't you remove unreachable()?

I did. I have have uploaded a change.

[kasperl, 2012-05-15 13:27:52]

I'm okay with this change (and it is always nice to get better error locations
for issues), so LGTM.

I think we should have a chat about good ways of making it easy to always be an
position where you have access to the compiler object and some kind of node.

[ahe, 2012-05-15 15:43:30]

On 2012/05/15 13:27:52, kasperl wrote:
> I'm okay with this change (and it is always nice to get better error locations
> for issues), so LGTM.
> 
> I think we should have a chat about good ways of making it easy to always be
an
> position where you have access to the compiler object and some kind of node.

Definitely. I need Lasse and Florian's help to figure out how to handle this. I
think we can afford to throw an exception like this:

class InternalCompilerError {
  String message;
  Node node;
  HInstruction instruction;
  Token token;
  Element element;
  InternalCompilerError(this.message, [this.node, this.instruction, this.token,
this.element]);
}

We can probably just catch this error in WorkItem.run and report a nicer
message.

This way we don't need access to the compiler object (essentially, we store it
on the stack).

It could make sense to have Node, HInstruction, Token, and Element all implement
a shared interface, say SourceLocation.