Add locations to diagnostics.

dart/lib/compiler/implementation/ssa/tracer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('tracer');
 
 #import('dart:io');
 #import('ssa.dart');
 #import('../leg.dart');
 
@@ skipping 142 matching lines @@
 }
 
 class HInstructionStringifier implements HVisitor<String> {
   HBasicBlock currentBlock;
 
   HInstructionStringifier(this.currentBlock);
 
   visit(HInstruction node) => node.accept(this);
 
   visitBasicBlock(HBasicBlock node) {
-    unreachable();
+    // TODO(floitsch): Need a compiler object.
+    compiler.internalError('conditionExpression should not be called',
+                           instruction: node);
   }
 
   String temporaryId(HInstruction instruction) {
     String prefix;
     HType type = instruction.propagatedType;
     if (!type.isPrimitive()) {
       prefix = 'U';
     } else {
       switch (type) {
         case HType.MUTABLE_ARRAY: prefix = 'm'; break;
@@ skipping 239 matching lines @@
       case HType.MUTABLE_ARRAY: type = "mutable_array"; break;
       case HType.READABLE_ARRAY: type = "readable_array"; break;
       case HType.EXTENDABLE_ARRAY: type = "extendable_array"; break;
       case HType.BOOLEAN: type = "bool"; break;
       case HType.INTEGER: type = "integer"; break;
       case HType.DOUBLE: type = "double"; break;
       case HType.NUMBER: type = "number"; break;
       case HType.STRING: type = "string"; break;
       case HType.INDEXABLE_PRIMITIVE: type = "string_or_array"; break;
       case HType.UNKNOWN: type = 'unknown'; break;
-      default: unreachable();
+      default:
+        // TODO(floitsch): Need a compiler object.
+        compiler.internalError('Unexpected type guard.',
+                               instruction: node.guardedType);
+        break;
     }
     StringBuffer envBuffer = new StringBuffer();
     List<HInstruction> inputs = node.inputs;
     // The last input is the guarded expression.
     for (int i = 0; i < inputs.length - 1; i++) {
       envBuffer.add(" ${temporaryId(inputs[i])}");
     }
     String on = node.isOn ? "on" : "off";
     String id = temporaryId(node.guarded);
     return "TypeGuard($on): $id is $type env: $envBuffer";
   }
 
   String visitIs(HIs node) {
     String type = node.typeExpression.toString();
     return "TypeTest: ${temporaryId(node.expression)} is $type";
   }
 
   String visitTypeConversion(HTypeConversion node) {
     String type = node.propagatedType.toString();
     return "TypeConversion: ${temporaryId(node.inputs[0])} to $type";
   }
 }