Issue 10388159: Correctly handle the case of a 126 bytes long message, in WebSocket frame encoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388159: Correctly handle the case of a 126 bytes long message, in WebSocket frame encoding. (Closed)

Created:
8 years, 7 months ago by Anders Johnsen

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Correctly handle the case of a 126 bytes long message, in WebSocket frame encoding. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7678

Patch Set 2 : Add 65535 and 65536 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	runtime/bin/websocket_impl.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tests/standalone/io/web_socket_test.dart	View	1	2 chunks	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM, thanks https://chromiumcodereview.appspot.com/10388159/diff/1/tests/standalone/io/web_socket_test.dart File tests/standalone/io/web_socket_test.dart (right): https://chromiumcodereview.appspot.com/10388159/diff/1/tests/standalone/io/web_socket_test.dart#newcode325 tests/standalone/io/web_socket_test.dart:325: testMessageLength(127); Maybe add 65535 og 65536

8 years, 7 months ago (2012-05-16 08:34:40 UTC) #2

Anders Johnsen

8 years, 7 months ago (2012-05-16 08:43:01 UTC) #3

Committing.

https://chromiumcodereview.appspot.com/10388159/diff/1/tests/standalone/io/we...
File tests/standalone/io/web_socket_test.dart (right):

https://chromiumcodereview.appspot.com/10388159/diff/1/tests/standalone/io/we...
tests/standalone/io/web_socket_test.dart:325: testMessageLength(127);
On 2012/05/16 08:34:40, Søren Gjesse wrote:
> Maybe add 65535 og 65536

Done.

Expand Messages | Collapse Messages

Issue 10388159: Correctly handle the case of a 126 bytes long message, in WebSocket frame encoding. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add 65535 and 65536 #

Messages