Correctly handle the case of a 126 bytes long message, in WebSocket frame encoding.

tests/standalone/io/web_socket_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 
 #import("dart:io");
 
 void testRequestResponseClientCloses(
     int totalConnections, int closeStatus, String closeReason) {
   HttpServer server = new HttpServer();
@@ skipping 84 matching lines @@
     WebSocketClientConnection wsconn = new WebSocketClientConnection(conn);
     wsconn.onMessage = (message) => wsconn.send(message);
     wsconn.onClosed = (status, reason) {
       Expect.equals(closeStatus, status);
       Expect.equals(closeReason, reason);
     };
   }
 }
 
 
+void testMessageLength(int messageLength) {
+  HttpServer server = new HttpServer();
+  HttpClient client = new HttpClient();
+
+  server.listen("127.0.0.1", 0, 1);
+
+  // Create a web socket handler and set is as the HTTP server default
+  // handler.
+  String originalMessage = "";
+  for (int i = 0; i < messageLength; i++) originalMessage += "${i % 10}";
+  WebSocketHandler wsHandler = new WebSocketHandler();
+  wsHandler.onOpen = (WebSocketConnection conn) {
+    conn.onMessage = (Object message) {
+      Expect.equals(originalMessage, message);
+      conn.send(message);
+    };
+    conn.onClosed = (status, reason) {
+    };
+  };
+  server.defaultRequestHandler = wsHandler.onRequest;
+
+  HttpClientConnection conn = client.get("127.0.0.1", server.port, "/");
+  WebSocketClientConnection wsconn = new WebSocketClientConnection(conn);
+  wsconn.onMessage = (message) {
+    Expect.equals(originalMessage, message);
+    wsconn.close();
+  };
+  wsconn.onClosed = (status, reason) {
+    server.close();
+  };
+  wsconn.onOpen = () {
+    wsconn.send(originalMessage);
+  };
+}
+
+
 void testNoUpgrade() {
   HttpServer server = new HttpServer();
   HttpClient client = new HttpClient();
 
   server.listen("127.0.0.1", 0, 5);
 
   // Create a server which always responds with a redirect.
   server.defaultRequestHandler = (request, response) {
     response.statusCode = HttpStatus.MOVED_PERMANENTLY;
     response.outputStream.close();
@@ skipping 162 matching lines @@
 }
 
 
 main() {
   testRequestResponseClientCloses(2, null, null);
   testRequestResponseClientCloses(2, 3001, null);
   testRequestResponseClientCloses(2, 3002, "Got tired");
   testRequestResponseServerCloses(2, null, null);
   testRequestResponseServerCloses(2, 3001, null);
   testRequestResponseServerCloses(2, 3002, "Got tired");
+  testMessageLength(125);
+  testMessageLength(126);
+  testMessageLength(127);

[Søren Gjesse, 2012/05/16 08:34:40]

Maybe add 65535 og 65536

[Anders Johnsen, 2012/05/16 08:43:01]

Done.

   testNoUpgrade();
   testUsePOST();
   testHashCode(2);
 
   testW3CInterface(2, 3002, "Got tired");
 }