Issue 10387232: Remove string concatenation with + from all Dart files in tools directory.

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed)

Created:
8 years, 7 months ago by Bill Hesse

Modified:
8 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove string concatenation with + from all Dart files in tools directory. Fix whitespace errors and rename shadowed variable in ddbg.dart. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7897

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -68 lines)			Patch
M	tools/ddbg.dart	View	1	2 chunks	+14 lines, -14 lines	0 comments	Download
M	tools/test.dart	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
M	tools/test-runtime.dart	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
M	tools/testing/dart/multitest.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_progress.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	tools/testing/frogpad/frogpad.dart	View	1	8 chunks	+18 lines, -17 lines	0 comments	Download
M	tools/testing/legpad/legpad.dart	View	1	4 chunks	+11 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. http://codereview.chromium.org/10387232/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): http://codereview.chromium.org/10387232/diff/1/tools/ddbg.dart#newcode61 tools/ddbg.dart:61: var command = args[0]; Nice change. :) http://codereview.chromium.org/10387232/diff/1/tools/test-runtime.dart ...

8 years, 7 months ago (2012-05-22 17:23:14 UTC) #2

Bill Hesse

8 years, 7 months ago (2012-05-23 08:49:20 UTC) #3

http://codereview.chromium.org/10387232/diff/1/tools/ddbg.dart
File tools/ddbg.dart (right):

http://codereview.chromium.org/10387232/diff/1/tools/ddbg.dart#newcode61
tools/ddbg.dart:61: var command = args[0];
On 2012/05/22 17:23:14, Bob Nystrom wrote:
> Nice change. :)

Or I could have just removed the inner "var" declarations - the outer "cmd"
variable (now "command") is dead at that point, so it could be reused for the
inner value.  Oh well.

http://codereview.chromium.org/10387232/diff/1/tools/test-runtime.dart
File tools/test-runtime.dart (right):

http://codereview.chromium.org/10387232/diff/1/tools/test-runtime.dart#newcode56
tools/test-runtime.dart:56: List<String> output_words = configurations.length >
1 ?
On 2012/05/22 17:23:14, Bob Nystrom wrote:
> I would use "var" for these locals.

Changed to List - it isn't much longer than var, and more informative.

Expand Messages | Collapse Messages