Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: tools/test-runtime.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/multitest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test-runtime.dart
diff --git a/tools/test-runtime.dart b/tools/test-runtime.dart
index 498a787311b741948a85810de43a07c2a5a72826..d3471a68cb05e19f6e0a2b301485f739067e8715 100755
--- a/tools/test-runtime.dart
+++ b/tools/test-runtime.dart
@@ -53,14 +53,15 @@ main() {
// test.dart. However, don't do it if the silent progress indicator
// is used. This is only needed because of the junit tests.
if (progressIndicator != 'silent') {
- StringBuffer sb = new StringBuffer('Test configuration');
- sb.add(configurations.length > 1 ? 's:' : ':');
+ List output_words = configurations.length > 1 ?
+ ['Test configurations:'] : ['Test configuration:'];
for (Map conf in configurations) {
- sb.add(' ${conf["compiler"]}_${conf["runtime"]}_${conf["mode"]}_' +
- '${conf["arch"]}');
- if (conf['checked']) sb.add('_checked');
+ List settings =
+ ['compiler', 'runtime', 'mode', 'arch'].map((name) => conf[name]);
+ if (conf['checked']) settings.add('checked');
+ output_words.add(Strings.join(settings, '_'));
}
- print(sb);
+ print(Strings.join(output_words, ' '));
}
var configurationIterator = configurations.iterator();
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/multitest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698