Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 10384016: Eliminate busy waiting for debugger connection (Closed)

Created:
8 years, 7 months ago by hausner
Modified:
8 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate busy waiting for debugger connection Committed: https://code.google.com/p/dart/source/detail?r=7348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M runtime/bin/dbg_connection.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection.cc View 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
8 years, 7 months ago (2012-05-04 20:59:39 UTC) #1
siva
LGTM Though I still don't get what purpose is served by starting the other thread ...
8 years, 7 months ago (2012-05-04 21:23:15 UTC) #2
hausner
Thanks. You are right, it is overkill at this point to have a separate listener ...
8 years, 7 months ago (2012-05-04 21:25:20 UTC) #3
siva
8 years, 7 months ago (2012-05-04 21:41:57 UTC) #4
I agree.

It is just that we are pretty early in the development of the protocol and it is
not clear how the multiple isolate situation is going to evolve. When that
becomes clear it is possible that we may conclude it is better to re use the
messaging infrastructure we already have.

On 2012/05/04 21:25:20, hausner wrote:
> Thanks. You are right, it is overkill at this point to have a separate
listener
> thread. I'll need it in the future though and don't want to throw away that
code
> in the meantime.

Powered by Google App Engine
This is Rietveld 408576698