Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: runtime/bin/dbg_connection.h

Issue 10384016: Eliminate busy waiting for debugger connection (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/dbg_connection.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef BIN_DBG_CONNECTION_H_ 5 #ifndef BIN_DBG_CONNECTION_H_
6 #define BIN_DBG_CONNECTION_H_ 6 #define BIN_DBG_CONNECTION_H_
7 7
8 #include "bin/builtin.h" 8 #include "bin/builtin.h"
9 #include "bin/utils.h" 9 #include "bin/utils.h"
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 // The socket that is listening for incoming debugger connections. 50 // The socket that is listening for incoming debugger connections.
51 // This descriptor is created and closed by a VM thread. 51 // This descriptor is created and closed by a VM thread.
52 static int listener_fd_; 52 static int listener_fd_;
53 53
54 // The socket that connects with the debugger client. 54 // The socket that connects with the debugger client.
55 // The descriptor is created by the debugger connection thread and 55 // The descriptor is created by the debugger connection thread and
56 // closed by a VM thread. 56 // closed by a VM thread.
57 static int debugger_fd_; 57 static int debugger_fd_;
58 58
59 // The VM thread waits on this condition variable when it reaches a
60 // breakpoint and the debugger client has not connected yet.
61 static dart::Monitor is_connected_;
62
59 static MessageBuffer* msgbuf_; 63 static MessageBuffer* msgbuf_;
60 64
61 friend class DebuggerConnectionImpl; 65 friend class DebuggerConnectionImpl;
62 66
63 DISALLOW_ALLOCATION(); 67 DISALLOW_ALLOCATION();
64 DISALLOW_IMPLICIT_CONSTRUCTORS(DebuggerConnectionHandler); 68 DISALLOW_IMPLICIT_CONSTRUCTORS(DebuggerConnectionHandler);
65 }; 69 };
66 70
67 #endif // BIN_DBG_CONNECTION_H_ 71 #endif // BIN_DBG_CONNECTION_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/dbg_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698