Issue 10381150: Fix directory listing to actually have the semantics intended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10381150: Fix directory listing to actually have the semantics intended. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix directory listing to actually have the semantics intended. The directory listing will continue on error (such as broken links) and the boolean indication when listing is complete will signal if all operations succeeded. R=sgjesse@google.com BUG=dartbug.com/3031 TEST=standalone/io/file_system_links_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7655

Patch Set 1 #

Patch Set 2 : Windows part #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -26 lines)			Patch
M	runtime/bin/directory_posix.cc	View		2 chunks	+19 lines, -20 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	tests/standalone/io/file_system_links_test.dart	View		2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages