Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: runtime/bin/directory_win.cc

Issue 10381150: Fix directory listing to actually have the semantics intended. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Windows part Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory_posix.cc ('k') | tests/standalone/io/file_system_links_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory_win.cc
diff --git a/runtime/bin/directory_win.cc b/runtime/bin/directory_win.cc
index a2c4ec031cc54222989768be87f692fc5b0ae617..0fb1e1e245e3e29691162a3eb6bdad01831a9693 100644
--- a/runtime/bin/directory_win.cc
+++ b/runtime/bin/directory_win.cc
@@ -165,12 +165,12 @@ static bool ListRecursively(const char* dir_name,
recursive,
listing);
- while ((FindNextFile(find_handle, &find_file_data) != 0) && success) {
- success = success && HandleEntry(&find_file_data,
- path,
- path_length,
- recursive,
- listing);
+ while ((FindNextFile(find_handle, &find_file_data) != 0)) {
+ success = HandleEntry(&find_file_data,
+ path,
+ path_length,
+ recursive,
+ listing) && success;
}
if (GetLastError() != ERROR_NO_MORE_FILES) {
« no previous file with comments | « runtime/bin/directory_posix.cc ('k') | tests/standalone/io/file_system_links_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698