Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 10378044: Rely on dart:io to deal with symlinks in pub. (Closed)

Created:
8 years, 7 months ago by nweiz
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rely on dart:io to deal with symlinks in pub. Now that issue 2516 is solved, we don't need these hacks. Committed: https://code.google.com/p/dart/source/detail?r=7428

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M utils/pub/io.dart View 3 chunks +0 lines, -27 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
8 years, 7 months ago (2012-05-08 01:26:36 UTC) #1
Bob Nystrom
A truly beautiful patch. It warms my heart to see hacks get deleted. LGTM.
8 years, 7 months ago (2012-05-08 16:49:19 UTC) #2
Mads Ager (google)
Nice! Happy to see this working without the hacks! :) https://chromiumcodereview.appspot.com/10378044/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://chromiumcodereview.appspot.com/10378044/diff/1/utils/pub/io.dart#newcode297 ...
8 years, 7 months ago (2012-05-09 10:06:23 UTC) #3
Bob Nystrom
8 years, 7 months ago (2012-05-09 15:49:11 UTC) #4
https://chromiumcodereview.appspot.com/10378044/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10378044/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:297: Future<ProcessResult> runProcess(String executable,
List<String> args,
On 2012/05/09 10:06:23, Mads Ager wrote:
> We should see if we can use:
> 
> new Process.run(..., (exitCode, stdout, stderr) {
>   ...
> });
> 
> for this as well. That returns strings and not a list of lines though.

Good call. I wrote this before Process.run was finished but we will probably
change to use that at some point.

Powered by Google App Engine
This is Rietveld 408576698