Rely on dart:io to deal with symlinks in pub.

utils/pub/io.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Helper functionality to make working with IO easier.
  */
 #library('pub_io');
 
 #import('dart:io');
@@ skipping 73 matching lines @@
     return results[0] || results[1];
   });
 }
 
 /**
  * Asynchronously determines if [file], which can be a [String] file path or a
  * [File], exists on the file system. Returns a [Future] that completes with
  * the result.
  */
 Future<bool> fileExists(file) {
-  // TODO(nweiz): Currently File#exists will not detect the existence of
-  // symlinks. Issue 2765
-  return runProcess('stat', [_getPath(file)]).
-    transform((result) => result.exitCode == 0);
-
-  // Real code:
-  /*
   final completer = new Completer<bool>();
 
   file = new File(_getPath(file));
   file.onError = (error) => completer.completeException(error);
   file.exists((exists) => completer.complete(exists));
 
   return completer.future;
-  */
 }
 
 /**
  * Reads the contents of the text file [file], which can either be a [String] or
  * a [File].
  */
 Future<String> readTextFile(file) {
   file = new File(_getPath(file));
   final completer = new Completer<String>();
   file.onError = (error) => completer.completeException(error);
@@ skipping 74 matching lines @@
   dir.createTemp(() => completer.complete(dir));
 
   return completer.future;
 }
 
 /**
  * Asynchronously recursively deletes [dir], which can be a [String] or a
  * [Directory]. Returns a [Future] that completes when the deletion is done.
  */
 Future<Directory> deleteDir(dir) {
-  // TODO(rnystrom): Hack! Temporary! Right now, dart:io's Directory delete
-  // method can't handle directories with symlinks, which is exactly what pub
-  // creates and deletes. Instead, we'll just shell out to 'rm'. Remove this
-  // when dartbug.com/2646 is fixed.
-  dir = _getDirectory(dir);
-
-  // Sanity check!
-  if (dir.path == '/' ||
-      dir.path == '.' ||
-      dir.path == '..' ||
-      dir.path == '~' ||
-      dir.path == '*') throw "(O.o) I don't think you want to do that!";
-
-  return runProcess('rm', ['-rf', dir.path]).transform((_) => dir);
-  // End hack!
-
-  // Real code:
-  /*
   final completer = new Completer<Directory>();
   dir = _getDirectory(dir);
   dir.onError = (error) => completer.completeException(error);
   dir.deleteRecursively(() => completer.complete(dir));
 
   return completer.future;
-  */
 }
 
 /**
  * Asynchronously lists the contents of [dir], which can be a [String] directory
  * path or a [Directory]. If [recursive] is `true`, lists subdirectory contents
  * (defaults to `false`). If [includeSpecialFiles] is `true`, includes
  * hidden `.DS_Store` files (defaults to `false`, other hidden files may be
  * omitted later).
  */
 Future<List<String>> listDir(dir,
@@ skipping 76 matching lines @@
  * the current working directory, returns its full canonicalized path.
  */
 // TODO(rnystrom): Should this be async?
 String getFullPath(entry) => new File(_getPath(entry)).fullPathSync();
 
 /**
  * Spawns and runs the process located at [executable], passing in [args].
  * Returns a [Future] that will complete the results of the process after it
  * has ended.
  */
 Future<ProcessResult> runProcess(String executable, List<String> args,

[Mads Ager (google), 2012/05/09 10:06:23]

We should see if we can use:

new Process.run(..., (exitCode, stdout, stderr) {
  ...
});

for this as well. That returns strings and not a list of lines though.

[Bob Nystrom, 2012/05/09 15:49:11]

Good call. I wrote this before Process.run was finished but we will probably
change to use that at some point.

     [String workingDir]) {
   int exitCode;
 
   final options = new ProcessOptions();
   if (workingDir != null) options.workingDirectory = workingDir;
 
   final process = new Process.start(executable, args, options);
 
   final outStream = new StringInputStream(process.stdout);
   final processStdout = <String>[];
@@ skipping 55 matching lines @@
 }
 
 /**
  * Gets a [Directory] for [entry], which can either already be one, or be a
  * [String].
  */
 Directory _getDirectory(entry) {
   if (entry is Directory) return entry;
   return new Directory(entry);
 }