Issue 10377095: Implement latest rules prohibiting some self referencing typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377095: Implement latest rules prohibiting some self referencing typedefs. (Closed)

Created:
8 years, 7 months ago by regis

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement latest rules prohibiting some self referencing typedefs. Update tests. Committed: https://code.google.com/p/dart/source/detail?r=7524

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -59 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	11 chunks	+106 lines, -32 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	5 chunks	+22 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/language/function_type_alias5_test.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	tests/language/function_type_alias6_test.dart	View	1	1 chunk	+16 lines, -4 lines	0 comments	Download
D	tests/language/function_type_alias7_test.dart	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	tests/language/language.status	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with the comment to use class indexes instead of objects in the visited array. ...

8 years, 7 months ago (2012-05-10 22:28:21 UTC) #2

regis

8 years, 7 months ago (2012-05-10 22:56:00 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10377095/diff/1/runtime/vm/class_final...
File runtime/vm/class_finalizer.cc (right):

https://chromiumcodereview.appspot.com/10377095/diff/1/runtime/vm/class_final...
runtime/vm/class_finalizer.cc:1185: const GrowableObjectArray& visited) {
On 2012/05/10 22:28:21, srdjan wrote:
> You should be using class index instead of class for 'visited' ->
> GrowableArray<intptr_t>

Done. I have also done this in ResolveInterfaces.

Expand Messages | Collapse Messages