Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: runtime/vm/parser.cc

Issue 10377095: Implement latest rules prohibiting some self referencing typedefs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/function_type_alias5_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 7523)
+++ runtime/vm/parser.cc (working copy)
@@ -2962,6 +2962,10 @@
Class::NewSignatureClass(*alias_name,
signature_function,
script_));
+ // This alias should not be marked as finalized yet, since it needs to be
+ // checked in the class finalizer for illegal self references.
+ ASSERT(!function_type_alias.IsCanonicalSignatureClass());
+ ASSERT(!function_type_alias.is_finalized());
library_.AddClass(function_type_alias);
ExpectSemicolon();
pending_classes.Add(function_type_alias, Heap::kOld);
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/function_type_alias5_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698