Create isolate constructor dynamically.

Create isolate constructor dynamically.

This should remove the huge speed regression we got by adding
'defineClass'.

Committed: https://code.google.com/p/dart/source/detail?r=7289

[kasperl, 2012-05-03 12:30:18]

LGTM.

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:33: String initialStatics;
isolateProperties?

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:44: String get defineClassName() =>
'${namer.ISOLATE}.\$defineClass';
I think I'd prefer to break before => in this entire section because it looks
less messy to me.

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:52: String get defineClassFunction() {
It feels a bit weird to me that these are getters.

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:138: """/* We fetch the initial static
values from the same location as before. */"""
Somehow this "embedded comment" make it harder to understand -- not easier. How
bad would it be to move it out to before the return statement and add a few
extra sentences to explain what it is doing from a high level?

[floitsch, 2012-05-03 14:24:01]

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:33: String initialStatics;
On 2012/05/03 12:30:18, kasperl wrote:
> isolateProperties?

Done.

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:44: String get defineClassName() =>
'${namer.ISOLATE}.\$defineClass';
On 2012/05/03 12:30:18, kasperl wrote:
> I think I'd prefer to break before => in this entire section because it looks
> less messy to me.

Done.

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:52: String get defineClassFunction() {
On 2012/05/03 12:30:18, kasperl wrote:
> It feels a bit weird to me that these are getters.
If they weren't going through other getters (which need the dynamically
allocated namer) these would be constant fields.
From this point of view I prefer keeping them as getters.

https://chromiumcodereview.appspot.com/10363002/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:138: """/* We fetch the initial static
values from the same location as before. */"""
On 2012/05/03 12:30:18, kasperl wrote:
> Somehow this "embedded comment" make it harder to understand -- not easier.
How
> bad would it be to move it out to before the return statement and add a few
> extra sentences to explain what it is doing from a high level?

Done.

[ngeoffray, 2012-05-07 09:48:45]

https://chromiumcodereview.appspot.com/10363002/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10363002/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:165: str += "this." + staticName + "=
isolateProperties." + staticName + ";\\n";
line too long

[floitsch, 2012-05-07 14:09:10]

https://chromiumcodereview.appspot.com/10363002/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10363002/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:165: str += "this." + staticName + "=
isolateProperties." + staticName + ";\\n";
On 2012/05/07 09:48:45, ngeoffray wrote:
> line too long
done in CL 10388006.