Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10363002: Create isolate constructor dynamically. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments and fixed bugs. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/emitter.dart » ('j') | lib/compiler/implementation/emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compile_time_constants.dart
diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart
index 8b9dafcf095cad599ddc51ece3e76801c2f062a6..775331746dd8bf4755f0fcac031124db364cf466 100644
--- a/lib/compiler/implementation/compile_time_constants.dart
+++ b/lib/compiler/implementation/compile_time_constants.dart
@@ -265,8 +265,7 @@ class ObjectConstant extends Constant {
void _writeCanonicalizedJsCode(StringBuffer buffer, ConstantHandler handler) {
String name = handler.getNameForConstant(this);
- String isolatePrototype = "${handler.compiler.namer.ISOLATE}.prototype";
- buffer.add("$isolatePrototype.$name");
+ buffer.add(handler.compiler.namer.isolatePropertiesAccessForConstant(name));
}
}
@@ -285,8 +284,7 @@ class ListConstant extends ObjectConstant {
void _writeJsCode(StringBuffer buffer, ConstantHandler handler) {
// TODO(floitsch): we should not need to go through the compiler to make
// the list constant.
- String isolatePrototype = "${handler.compiler.namer.ISOLATE}.prototype";
- buffer.add("$isolatePrototype.makeConstantList");
+ buffer.add("${handler.compiler.namer.ISOLATE}.makeConstantList");
buffer.add("([");
for (int i = 0; i < entries.length; i++) {
if (i != 0) buffer.add(", ");
@@ -693,7 +691,7 @@ class ConstantHandler extends CompilerTask {
}
String getJsConstructor(ClassElement element) {
- return compiler.namer.isolatePropertyAccess(element);
+ return compiler.namer.isolatePropertiesAccess(element);
}
}
« no previous file with comments | « no previous file | lib/compiler/implementation/emitter.dart » ('j') | lib/compiler/implementation/emitter.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698