Issue 10350003: Step toward eliminating increment nodes, starting with increment local. Fix a bug in evaluating sid…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10350003: Step toward eliminating increment nodes, starting with increment local. Fix a bug in evaluating sid… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Step toward eliminating increment nodes, starting with increment local. Fix a bug in evaluating side effect free nodes. Committed: https://code.google.com/p/dart/source/detail?r=7300

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -226 lines)			Patch
M	runtime/vm/ast.h	View	1	2 chunks	+0 lines, -30 lines	0 comments	Download
M	runtime/vm/ast.cc	View	1	3 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/ast_printer.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+0 lines, -48 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1	1 chunk	+0 lines, -56 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	14 chunks	+39 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM. It took me a while to grok the idea. I think it would be ...

8 years, 7 months ago (2012-05-03 17:04:41 UTC) #2

srdjan

8 years, 7 months ago (2012-05-03 20:16:47 UTC) #3

Yes, we should come up with a better name than pseudo input.

https://chromiumcodereview.appspot.com/10350003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10350003/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:5909: new LocalVariable(0,
On 2012/05/03 17:04:41, hausner wrote:
> Just a gut feeling, but I'd prefer the token position of the function rather
> than 0.

Done.

Expand Messages | Collapse Messages