Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 10350003: Step toward eliminating increment nodes, starting with increment local. Fix a bug in evaluating sid… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/code_generator_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 7298)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1179,33 +1179,6 @@
}
-void CodeGenerator::VisitIncrOpLocalNode(IncrOpLocalNode* node) {
- ASSERT((node->kind() == Token::kINCR) || (node->kind() == Token::kDECR));
- MarkDeoptPoint(node->id(), node->token_index());
- GenerateLoadVariable(EAX, node->local());
- if (!node->prefix() && IsResultNeeded(node)) {
- // Preserve as result.
- __ pushl(EAX);
- }
- const char* operator_name = (node->kind() == Token::kINCR) ? "+" : "-";
- __ pushl(EAX);
- __ pushl(Immediate(Smi::RawValue(1)));
- GenerateBinaryOperatorCall(node->id(), node->token_index(), operator_name);
- // result is in EAX.
- if (FLAG_enable_type_checks) {
- GenerateAssertAssignable(node->id(),
- node->token_index(),
- NULL,
- node->local().type(),
- node->local().name());
- }
- GenerateStoreVariable(node->local(), EAX, EDX);
- if (node->prefix() && IsResultNeeded(node)) {
- __ pushl(EAX);
- }
-}
-
-
void CodeGenerator::VisitIncrOpInstanceFieldNode(
IncrOpInstanceFieldNode* node) {
ASSERT((node->kind() == Token::kINCR) || (node->kind() == Token::kDECR));
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/code_generator_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698