Call 'use' instead of 'visit' on the input when generating code for an unchecked HTypeConversion.

Call 'use' instead of 'visit' on the input when generating code for an unchecked HTypeConversion.
Committed: https://code.google.com/p/dart/source/detail?r=7454

[ngeoffray, 2012-05-09 11:52:34]

This is fixing a regression I introduced with the new way we handle generate at
use site for check instructions. We need to call use because a HTypeConversion
may contain another HCheck as input.

[floitsch, 2012-05-09 12:05:21]

LGTM.

[Lasse Reichstein Nielsen, 2012-05-10 08:16:54]

https://chromiumcodereview.appspot.com/10332070/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10332070/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:2194: use(node.checkedInput,
expectedPrecedence);
I think we are getting to the point where "visit" is too generic. There are
several other ways to 'visit' an instruction ("use", "declare"), so perhaps we
should rename "visit" to "generateOperation", or just "generate", to make it
clearer that "visit" is an unconditional generation of the operation of an
instruction.

[ngeoffray, 2012-05-10 08:19:38]

https://chromiumcodereview.appspot.com/10332070/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10332070/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:2194: use(node.checkedInput,
expectedPrecedence);
On 2012/05/10 08:16:55, Lasse Reichstein Nielsen wrote:
> I think we are getting to the point where "visit" is too generic. There are
> several other ways to 'visit' an instruction ("use", "declare"), so perhaps we
> should rename "visit" to "generateOperation", or just "generate", to make it
> clearer that "visit" is an unconditional generation of the operation of an
> instruction.

Agree.