Call 'use' instead of 'visit' on the input when generating code for an unchecked HTypeConversion.

dart/lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
 
   String buildJavaScriptFunction(FunctionElement element,
@@ skipping 2173 matching lines @@
       }
       Element helperElement = compiler.findHelper(helper);
       compiler.registerStaticUse(helperElement);
       buffer.add(compiler.namer.isolateAccess(helperElement));
       buffer.add('(');
       use(node.checkedInput, JSPrecedence.EXPRESSION_PRECEDENCE);
       if (additionalArgument !== null) buffer.add(", '$additionalArgument'");
       buffer.add(')');
       endExpression(JSPrecedence.CALL_PRECEDENCE);
     } else {
-      visit(node.checkedInput, expectedPrecedence);
+      use(node.checkedInput, expectedPrecedence);

[Lasse Reichstein Nielsen, 2012/05/10 08:16:55]

I think we are getting to the point where "visit" is too generic. There are
several other ways to 'visit' an instruction ("use", "declare"), so perhaps we
should rename "visit" to "generateOperation", or just "generate", to make it
clearer that "visit" is an unconditional generation of the operation of an
instruction.

[ngeoffray, 2012/05/10 08:19:38]

Agree.

     }
   }
 }
 
 class SsaOptimizedCodeGenerator extends SsaCodeGenerator {
   SsaOptimizedCodeGenerator(compiler, work, parameters, parameterNames)
     : super(compiler, work, parameters, parameterNames);
 
   void beginGraph(HGraph graph) {}
   void endGraph(HGraph graph) {}
@@ skipping 388 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }