Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10304018: lingering step 2 of the test rename overhaul: make await tests also a directory (Closed)

Created:
8 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

lingering step 2 of the test rename overhaul: make await tests also a directory test rule Committed: https://code.google.com/p/dart/source/detail?r=7263

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -24 lines) Patch
M frog/tests/await/and_normalization_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/and_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/await_no_value_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/binary_expression_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/chaining_await_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional2_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional2_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional3_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional_normalization_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/conditional_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/dot_expression_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/doubly_nested_function_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/initializer_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/mint_maker_rpc_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/multiple_declarations_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_function2_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_function_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_try_catch2_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_try_catch3_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_try_catch4_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_try_catch5_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/nested_try_catch_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/or_normalization_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/or_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/single_await2_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/single_await_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/single_await_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/switch_statement_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
D frog/tests/await/test_config.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M frog/tests/await/top_level_function_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch10_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch2_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch3_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch4_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch5_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch6_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch7_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch8_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch9_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/try_catch_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/typed_function2_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/typed_function3_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/typed_function_negative_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/typed_function_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/while_loop_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/while_loop_with_break_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M frog/tests/await/while_normalization_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M tools/test.dart View 1 2 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
8 years, 7 months ago (2012-05-02 22:46:59 UTC) #1
Emily Fortuna
lgtm with comment. https://chromiumcodereview.appspot.com/10304018/diff/3001/frog/tests/await/binary_expression_normalization_test.dart File frog/tests/await/binary_expression_normalization_test.dart (right): https://chromiumcodereview.appspot.com/10304018/diff/3001/frog/tests/await/binary_expression_normalization_test.dart#newcode5 frog/tests/await/binary_expression_normalization_test.dart:5: // Pass VM options to run ...
8 years, 7 months ago (2012-05-02 23:11:09 UTC) #2
Siggi Cherem (dart-lang)
8 years, 7 months ago (2012-05-02 23:21:00 UTC) #3 
done

https://chromiumcodereview.appspot.com/10304018/diff/3001/frog/tests/await/bi...
File frog/tests/await/binary_expression_normalization_test.dart (right):

https://chromiumcodereview.appspot.com/10304018/diff/3001/frog/tests/await/bi...
frog/tests/await/binary_expression_normalization_test.dart:5: // Pass VM options
to run test through the awaitc compiler:
On 2012/05/02 23:11:09, Emily Fortuna wrote:
> This comment is perhaps a little too terse to be understandable. Please adjust
> like we discussed.

Done.

Powered by Google App Engine
This is Rietveld 408576698