Issue 10264021: Fix codegen and isolate issues for frog dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10264021: Fix codegen and isolate issues for frog dart:html (Closed)

Created:
8 years, 7 months ago by sra1

Modified:
8 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang), kasperl

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix codegen and isolate issues for frog dart:html Fixes issue 2835. dart:html now partakes in the logic that wraps functions that smell like call-backs in the isolate-management code. Support 2-arg callbacks. Delete special (and buggy) handling of global variables in 'native' libraries. We don't have any real 'native' global variables. Committed: https://code.google.com/p/dart/source/detail?r=7174

Patch Set 1 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -23 lines)			Patch
M	frog/corejs.dart	View	4 chunks	+10 lines, -7 lines	0 comments	Download
M	frog/gen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/library.dart	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	frog/member.dart	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	frog/member_set.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/value.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	frog/world.dart	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	lib/isolate/frog/natives.js	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 7 months ago (2012-05-01 06:02:49 UTC) #3

Hi Stephen! Thanks for keeping me in the loop. Any test cases for this?

Expand Messages | Collapse Messages