Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: frog/member.dart

Issue 10264021: Fix codegen and isolate issues for frog dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/library.dart ('k') | frog/member_set.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index 855e2893965257ed2e2f5decea815c3f609224fe..1f6e556aec220b23a8c6e18b8af92d8d8e5be180 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -541,12 +541,7 @@ class FieldMember extends Member {
}
world.gen.hasStatics = true;
if (declaringType.isTop) {
- if (declaringType.library.isDom) {
- // TODO(jmesserly): this check doesn't look right.
- return new Value(type, '$jsname', node.span);
- } else {
- return new Value(type, '\$globals.$jsname', node.span);
- }
+ return new Value(type, '\$globals.$jsname', node.span);
} else if (declaringType.isNative) {
if (declaringType.isHiddenNativeType) {
// TODO: Could warn at parse time.
@@ -1126,7 +1121,7 @@ class MethodMember extends Member {
}
// TODO(jmesserly): factor this better
- if (name == 'get:typeName' && declaringType.library.isDom) {
+ if (name == 'get:typeName' && declaringType.library.isDomOrHtml) {
world.gen.corejs.ensureTypeNameOf();
}
« no previous file with comments | « frog/library.dart ('k') | frog/member_set.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698