test rename overhaul: step 8 - language tests

test rename overhaul: step 8 - language tests

Committed: https://code.google.com/p/dart/source/detail?r=7101

[Siggi Cherem (dart-lang), 2012-04-27 02:27:30]

... still running tests, I might have a couple minor fixes before I submit, but
I don't expect them to be anything else other than fixing some missing
lowercases in source files here and there.

[Ivan Posva, 2012-04-27 05:36:39]

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/test.dart#newcode1
tools/test.dart:1: #!/usr/bin/env dart
ditto: test-runtime.dart

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_runner.dart:81: // TODO(sigmund): dissallow NegativeTest
once the test rename overhaul is
Care to explain? Negative tests are occasionally very useful and still should be
supported.

[Bob Nystrom, 2012-04-27 15:55:06]

LGTM

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/test.dart
File tools/test.dart (left):

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/test.dart#oldcode44
tools/test.dart:44: #import("../tests/language/test_config.dart");
\o/

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_runner.dart:81: // TODO(sigmund): dissallow NegativeTest
once the test rename overhaul is
On 2012/04/27 05:36:39, Ivan Posva wrote:
> Care to explain? Negative tests are occasionally very useful and still should
be
> supported.

I think here Siggy just means removing the PascalCase clause
(displayName.contains("NegativeTest")) and only using the "negative_test" one
once all of the files are renamed.

From our conversation yesterday, I'm pretty sure Siggy still expects to support
negative tests.

[Siggi Cherem (dart-lang), 2012-04-30 16:32:55]

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/10248007/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_runner.dart:81: // TODO(sigmund): dissallow NegativeTest
once the test rename overhaul is
On 2012/04/27 15:55:06, Bob Nystrom wrote:
> On 2012/04/27 05:36:39, Ivan Posva wrote:
> > Care to explain? Negative tests are occasionally very useful and still
should
> be
> > supported.
> 
> I think here Siggy just means removing the PascalCase clause
> (displayName.contains("NegativeTest")) and only using the "negative_test" one
> once all of the files are renamed.
> 
> From our conversation yesterday, I'm pretty sure Siggy still expects to
support
> negative tests.

That's exactly what I meant - I'll rewrite the TODO to be more clear.

[ahe, 2012-05-09 23:49:10]

Did you intentionally delete language-leg.status?

Perhaps you didn't see that we expressed in a reply to sra on April 24 that we
still find the separate files useful for co19 and language?

Unless there is a strong reason to keep this in one file, I would prefer to have
separate files as long as we have as many fail,ok as we have. We've been using
this file very actively, and just avoiding conflicts when you're sitting in the
same room is hard.

Unless there are any objections, I'll restore the file myself when I find a good
time without too many pending CLs. Of course, this will be a good opportunity to
select a different name for the file.

[Siggi Cherem (dart-lang), 2012-05-10 00:45:01]

On 2012/05/09 23:49:10, ahe wrote:
> Did you intentionally delete language-leg.status?
> 
> Perhaps you didn't see that we expressed in a reply to sra on April 24 that we
> still find the separate files useful for co19 and language?
> 
> Unless there is a strong reason to keep this in one file, I would prefer to
have
> separate files as long as we have as many fail,ok as we have. We've been using
> this file very actively, and just avoiding conflicts when you're sitting in
the
> same room is hard.
> 
> Unless there are any objections, I'll restore the file myself when I find a
good
> time without too many pending CLs. Of course, this will be a good opportunity
to
> select a different name for the file.

Hi Peter,

Sorry for deleting the file. I didn't realize about this problem. In this case
we need some additional functionality in test.dart to support adding it back.

More precisely, with this change, I made 'language' make use of the new way of
registering test suites by just listing a directory in test.dart. This new way
eliminates the need for test_config.dart, but it assumes that there is a single
status file named X.status (if the directory name is X).

Adding support for X-leg.status or X-dart2js.status is possible and shouldn't be
too hard, but it will require some changes in test.dart.

In the test cleanup process I made most test suites use this style. I think it
is worth doing this fix rather than going back to specifying test_config.dart.
I'm happy to help in the process.