Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: tests/language/src/ListDoubleIndexInLoop2Test.dart

Issue 10248007: test rename overhaul: step 8 - language tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4 // Dart test program for testing arrays.
5
6 bar() => true;
7
8 tata() => 1.5;
9
10 // The type propagation in Dart2Js wrongly took the intersection of all incoming
11 // types in a loop-phi. In this case the back-edge brought type 'number' which,
12 // combined with 'integer' (i = 0) was narrowed to 'integer'. As a result no
13 // check was inserted for the list access.
14 foo(a) {
15 var i;
16 if (bar()) {
17 // t's desired type is conflicting. Once it is used as array receiver. And
18 // once as integer. The backward propagation thus can't decide.
19 // The forward declaration, however, will assign type num.
20 var t = 0 + tata();
21 i = t;
22 if (!bar()) t[0];
23 } else {
24 i = 0;
25 }
26 for (int j = 0; j < 1; j++) {
27 // The phi, combining the two 'i's must reach the conclusion that i is of
28 // type num and therefore needs a check before accessing the array.
29 a[i];
30 }
31 }
32
33 main() {
34 Expect.throws(() => foo([1, 2]));
35 }
OLDNEW
« no previous file with comments | « tests/language/src/LibrarySameNameUsedTest.dart ('k') | tests/language/src/ListDoubleIndexInLoopTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698