test rename overhaul: step 7 - corelib tests

test rename overhaul: step 7 - corelib tests

Committed: https://code.google.com/p/dart/source/detail?r=7096

[Ivan Posva, 2012-04-27 05:20:25]

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart#newcode1
tools/test.dart:1: #!/usr/bin/env dart
Please also update test-runtime.dart.

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart#newcode55
tools/test.dart:55: final TEST_SUITE_DIRECTORIES = const [
@whesse: Why do we need to list all of the directories here? The layout we had
initially made it possible to auto-discover all tests suites, using a simple
pattern:
$SRCROOT/*/tests/*
and
$SRCROOT/tests/*

At least for the standard test suites (eventually the vast majority) we should
recreate this useful property.

[Ivan Posva, 2012-04-27 05:20:51]

And LGTM.

-Ivan

[Bill Hesse, 2012-04-27 07:14:11]

lgtm

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart#newcode55
tools/test.dart:55: final TEST_SUITE_DIRECTORIES = const [
I would like to make this a goal, but there is one problem:
test suites with non-standard behavior still need to be specified with custom
subclasses.  Therefore, either the non-standard test suites need to be moved to
someplace else, like tests/special or custom_tests, or we need some way of
filtering them.


On 2012/04/27 05:20:26, Ivan Posva wrote:
> @whesse: Why do we need to list all of the directories here? The layout we had
> initially made it possible to auto-discover all tests suites, using a simple
> pattern:
> $SRCROOT/*/tests/*
> and
> $SRCROOT/tests/*
> 
> At least for the standard test suites (eventually the vast majority) we should
> recreate this useful property.

[Ivan Posva, 2012-04-27 08:49:40]

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart#newcode55
tools/test.dart:55: final TEST_SUITE_DIRECTORIES = const [
On 2012/04/27 07:14:11, Bill Hesse wrote:
> I would like to make this a goal, but there is one problem:
> test suites with non-standard behavior still need to be specified with custom
> subclasses.  Therefore, either the non-standard test suites need to be moved
to
> someplace else, like tests/special or custom_tests, or we need some way of
> filtering them.

As far as I know standard test suites do not have a test_config.dart file in
them, they do not need it. There you have your simple filter.

> 
> 
> On 2012/04/27 05:20:26, Ivan Posva wrote:
> > @whesse: Why do we need to list all of the directories here? The layout we
had
> > initially made it possible to auto-discover all tests suites, using a simple
> > pattern:
> > $SRCROOT/*/tests/*
> > and
> > $SRCROOT/tests/*
> > 
> > At least for the standard test suites (eventually the vast majority) we
should
> > recreate this useful property.
>

[Siggi Cherem (dart-lang), 2012-04-27 18:25:47]

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10244009/diff/1/tools/test.dart#newcode1
tools/test.dart:1: #!/usr/bin/env dart
On 2012/04/27 05:20:26, Ivan Posva wrote:
> Please also update test-runtime.dart.

Done.