test rename overhaul: step 7 - corelib tests

tools/test.dart

 #!/usr/bin/env dart

[Ivan Posva, 2012/04/27 05:20:26]

Please also update test-runtime.dart.

[Siggi Cherem (dart-lang), 2012/04/27 18:25:48]

Done.

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file is the entrypoint of the dart test suite.  This suite is used
  * to test:
  *
  *     1. the dart vm
  *     2. the frog compiler (compiles dart to js)
@@ skipping 20 matching lines @@
 #import("../client/tests/dartc/test_config.dart");
 #import("../compiler/tests/dartc/test_config.dart");
 #import("../frog/tests/await/test_config.dart");
 #import("../frog/tests/frog/test_config.dart");
 #import("../frog/tests/leg/test_config.dart");
 #import("../frog/tests/leg_only/test_config.dart");
 #import("../frog/tests/native/test_config.dart");
 #import("../runtime/tests/vm/test_config.dart");
 #import("../samples/tests/samples/test_config.dart");
 #import("../tests/co19/test_config.dart");
-#import("../tests/corelib/test_config.dart");
 #import("../tests/isolate/test_config.dart");
 #import("../tests/language/test_config.dart");
 #import("../tests/lib/test_config.dart");
 #import("../tests/standalone/test_config.dart");
 #import("../tests/utils/test_config.dart");
 
 /**
  * The directories that contain test suites which follow the conventions
  * required by [StandardTestSuite]'s forDirectory constructor.
  * New test suites should follow this convention because it makes it much
  * simpler to add them to test.dart.  Existing test suites should be
  * moved to here, if possible.
 */
 final TEST_SUITE_DIRECTORIES = const [

[Ivan Posva, 2012/04/27 05:20:26]

@whesse: Why do we need to list all of the directories here? The layout we had
initially made it possible to auto-discover all tests suites, using a simple
pattern:
$SRCROOT/*/tests/*
and
$SRCROOT/tests/*

At least for the standard test suites (eventually the vast majority) we should
recreate this useful property.

[Bill Hesse, 2012/04/27 07:14:11]

I would like to make this a goal, but there is one problem:
test suites with non-standard behavior still need to be specified with custom
subclasses.  Therefore, either the non-standard test suites need to be moved to
someplace else, like tests/special or custom_tests, or we need some way of
filtering them.


On 2012/04/27 05:20:26, Ivan Posva wrote:

[Ivan Posva, 2012/04/27 08:49:41]

As far as I know standard test suites do not have a test_config.dart file in
them, they do not need it. There you have your simple filter.

   'tests/benchmark_smoke',
+  'tests/corelib',
   'tests/dom',
   'tests/html',
   'tests/json',
   'utils/tests/css',
   'utils/tests/peg',
   'utils/tests/pub',
 ];
 
 main() {
   var startTime = new Date.now();
@@ skipping 30 matching lines @@
     if (!configurationIterator.hasNext()) {
       return false;
     }
 
     var conf = configurationIterator.next();
     for (String key in selectors.getKeys()) {
       if (key == 'samples') {
         queue.addTestSuite(new SamplesTestSuite(conf));
       } else if (key == 'standalone') {
         queue.addTestSuite(new StandaloneTestSuite(conf));
-      } else if (key == 'corelib') {
-        queue.addTestSuite(new CorelibTestSuite(conf));
       } else if (key == 'co19') {
         queue.addTestSuite(new Co19TestSuite(conf));
       } else if (key == 'language') {
         queue.addTestSuite(new LanguageTestSuite(conf));
       } else if (key == 'lib') {
         queue.addTestSuite(new LibTestSuite(conf));
       } else if (key == 'isolate') {
         queue.addTestSuite(new IsolateTestSuite(conf));
       } else if (key == 'utils') {
         queue.addTestSuite(new UtilsTestSuite(conf));
@@ skipping 31 matching lines @@
   // Start process queue.
   var queue = new ProcessQueue(maxProcesses,
                                progressIndicator,
                                startTime,
                                printTiming,
                                enqueueConfiguration,
                                verbose,
                                listTests,
                                keepGeneratedTests);
 }