Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 10232003: - Improve marking performance by pre-marking RawInstructions objects, (Closed)

Created:
8 years, 8 months ago by Ivan Posva
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Improve marking performance by pre-marking RawInstructions objects, since they are not currently being collected. - Update svn:ignore properties. Committed: https://code.google.com/p/dart/source/detail?r=6993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
8 years, 8 months ago (2012-04-26 07:57:24 UTC) #1
Mads Ager (google)
LGTM
8 years, 8 months ago (2012-04-26 08:01:29 UTC) #2
ahe
8 years, 6 months ago (2012-05-29 10:35:27 UTC) #3
This change to svn:ignore properties on runtime has broken incremental building
on Windows.

I assume this wasn't intentional and plan to restore it incremental Windows
building.

Powered by Google App Engine
This is Rietveld 408576698