runtime/vm/gc_marker.cc - Issue 10232003: - Improve marking performance by pre-marking RawInstructions objects,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 10232003: - Improve marking performance by pre-marking RawInstructions objects, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/gc_marker.cc

===================================================================

--- runtime/vm/gc_marker.cc (revision 6988)

+++ runtime/vm/gc_marker.cc (working copy)

@@ -170,12 +170,7 @@

return;

}

// TODO(iposva): merge old and code spaces.

- ASSERT(heap_->Contains(raw_addr));

- if (!page_space_->Contains(raw_addr)) {

- // TODO(iposva): Skip code space if marking data space and vice-versa.

- return;

- }

+ ASSERT(page_space_->Contains(raw_addr));

MarkAndPush(raw_obj);

}

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »