Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 10229002: test rename overhaul: step 10 - crypto tests, and add back other tests commited (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org, Bill Hesse
Visibility:
Public.

Description

test rename overhaul: step 10 - crypto tests, and add back other tests commited recently, but just before the rename overhaul. Committed: https://code.google.com/p/dart/source/detail?r=7115

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1567 lines) Patch
A + frog/tests/leg/boolified_operator_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
D frog/tests/leg/src/BoolifiedOperatorTest.dart View 1 1 chunk +0 lines, -74 lines 0 comments Download
A + frog/tests/leg_only/bailout_on_continue_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + frog/tests/leg_only/cascade_precedence_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M frog/tests/leg_only/leg_only.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
D frog/tests/leg_only/src/BailoutOnContinueTest.dart View 1 1 chunk +0 lines, -103 lines 0 comments Download
D frog/tests/leg_only/src/CascadePrecedenceTest.dart View 1 1 chunk +0 lines, -137 lines 0 comments Download
A + tests/language/operator5_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/src/Operator5Test.dart View 1 1 chunk +0 lines, -61 lines 0 comments Download
A + tests/lib/crypto/sha1_long_test_vectors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/crypto/sha1_short_test_vectors.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/crypto/sha1_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/crypto/sha256_long_test_vectors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/crypto/sha256_short_test_vectors.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/crypto/sha256_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D tests/lib/src/crypto/sha1Test.dart View 1 1 chunk +0 lines, -570 lines 0 comments Download
D tests/lib/src/crypto/sha1_short_test_vectors.dart View 1 1 chunk +0 lines, -142 lines 0 comments Download
D tests/lib/src/crypto/sha256Test.dart View 1 1 chunk +0 lines, -315 lines 0 comments Download
D tests/lib/src/crypto/sha256_short_test_vectors.dart View 1 1 chunk +0 lines, -142 lines 0 comments Download
D tests/lib/test_config.dart View 1 1 chunk +0 lines, -17 lines 0 comments Download
M tools/test.dart View 1 3 chunks +1 line, -3 lines 0 comments Download
M tools/test-runtime.dart View 1 3 chunks +1 line, -4 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
Note: I'm making that by default 'forDirectory' is recursive.
8 years, 8 months ago (2012-04-27 22:59:47 UTC) #1
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-27 23:33:29 UTC) #2
Bob Nystrom
LGTM!
8 years, 8 months ago (2012-04-28 00:01:04 UTC) #3
Emily Fortuna
https://chromiumcodereview.appspot.com/10229002/diff/1/frog/tests/leg/boolified_operator_test.dart File frog/tests/leg/boolified_operator_test.dart (right): https://chromiumcodereview.appspot.com/10229002/diff/1/frog/tests/leg/boolified_operator_test.dart#newcode5 frog/tests/leg/boolified_operator_test.dart:5: #library("boolified_operator_test.dart"); love that test name. https://chromiumcodereview.appspot.com/10229002/diff/1/frog/tests/leg_only/leg_only.status File frog/tests/leg_only/leg_only.status (right): ...
8 years, 8 months ago (2012-04-28 00:06:14 UTC) #4
Siggi Cherem (dart-lang)
thx https://chromiumcodereview.appspot.com/10229002/diff/1/frog/tests/leg_only/leg_only.status File frog/tests/leg_only/leg_only.status (right): https://chromiumcodereview.appspot.com/10229002/diff/1/frog/tests/leg_only/leg_only.status#newcode22 frog/tests/leg_only/leg_only.status:22: [ $compiler == dartc || $runtime == vm ...
8 years, 8 months ago (2012-04-28 00:08:55 UTC) #5
Emily Fortuna
8 years, 8 months ago (2012-04-28 00:10:25 UTC) #6
k, lgtm!

Powered by Google App Engine
This is Rietveld 408576698