test rename overhaul: step 10 - crypto tests, and add back other tests commited

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 194 matching lines @@
   List<String> statusFilePaths;
   Function doTest;
   Function doDone;
   int activeTestGenerators = 0;
   bool listingDone = false;
   TestExpectations testExpectations;
   List<TestInformation> cachedTests;
   final String dartDir;
   Function globalTemporaryDirectory;
   Predicate<String> isTestFilePredicate;
+  bool _listRecursive;

[Emily Fortuna, 2012/04/28 00:06:14]

Where is this used? I couldn't find it in the CL.

[Siggi Cherem (dart-lang), 2012/04/28 00:08:55]

the crypto tests are under lib/crypto, but the test suite name is lib/. this is
so that future libraries will just work.

 
   StandardTestSuite(Map this.configuration,
                     String this.suiteName,
                     String this.directoryPath,
                     List<String> this.statusFilePaths,
-                    [Predicate<String> this.isTestFilePredicate])
-    : dartDir = TestUtils.dartDir();
+                    [Predicate<String> this.isTestFilePredicate,
+                    bool recursive = false])
+    : dartDir = TestUtils.dartDir(), _listRecursive = recursive;
 
   /**
    * Creates a test suite whose file organization matches an expected structure.
    * To use this, your suite should look like:
    *
    *     dart/
    *       path/
    *         to/
    *           mytestsuite/
    *             mytestsuite.status
@@ skipping 14 matching lines @@
    * instead of having to create a custom [StandardTestSuite] subclass. In
    * particular, if you add 'path/to/mytestsuite' to [TEST_SUITE_DIRECTORIES]
    * in test.dart, this will all be set up for you.
    */
   factory StandardTestSuite.forDirectory(
       Map configuration, String directory) {
     final name = directory.substring(directory.lastIndexOf('/') + 1);
 
     return new StandardTestSuite(configuration,
         name, directory, ['$directory/$name.status'],
-        (filename) => filename.endsWith('_test.dart'));
+        (filename) => filename.endsWith('_test.dart'),
+        recursive: true);
   }
 
   /**
    * The default implementation assumes a file is a test if
    * it ends in "Test.dart".
    */
   bool isTestFile(String filename) {
     // Use the specified predicate, if provided.
     if (isTestFilePredicate != null) return isTestFilePredicate(filename);
 
     return filename.endsWith("Test.dart");
   }
 
-  bool listRecursively() => false;
+  bool listRecursively() => _listRecursive;
 
   String shellPath() => TestUtils.dartShellFileName(configuration);
 
   List<String> additionalOptions(String filename) => [];
 
   void forEachTest(Function onTest, Map testCache, String globalTempDir(),
                    [Function onDone = null]) {
     // If DumpRenderTree/Dartium is required, and not yet updated,
     // wait for update.
     var updater = runtimeUpdater(configuration['runtime']);
@@ skipping 1109 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }