Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 10224006: Make get_drt.py work in Windows. (Closed)

Created:
8 years, 8 months ago by Emily Fortuna
Modified:
8 years, 8 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make get_drt.py work in Windows. Committed: https://code.google.com/p/dart/source/detail?r=6969

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M tools/get_drt.py View 1 5 chunks +19 lines, -15 lines 0 comments Download
M tools/testing/perf_testing/run_perf_tests.py View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
lgtm :-)
8 years, 8 months ago (2012-04-25 18:34:22 UTC) #1
Emily Fortuna
https://chromiumcodereview.appspot.com/10224006/diff/1/tools/get_drt.py File tools/get_drt.py (right): https://chromiumcodereview.appspot.com/10224006/diff/1/tools/get_drt.py#newcode162 tools/get_drt.py:162: unzipped_dir = os.path.join(temp_dir, os.path.basename(latest)[:-4]) # remove .zip greater than ...
8 years, 8 months ago (2012-04-25 18:38:58 UTC) #2
Emily Fortuna
8 years, 8 months ago (2012-04-25 18:48:12 UTC) #3
lgtm!!

Powered by Google App Engine
This is Rietveld 408576698