Make get_drt.py work in Windows.

tools/testing/perf_testing/run_perf_tests.py

 #!/usr/bin/python
 
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import datetime
 import optparse
 import os
 from os.path import dirname, abspath
@@ skipping 383 matching lines @@
     if platform.system() == 'Windows':
       browsers += ['ie']
       has_shell = True
     if 'dartium' in browsers:
       # Fetch it if necessary.
       get_dartium = ['python',
                      os.path.join(DART_INSTALL_LOCATION, 'tools', 'get_drt.py'),
                      '--dartium']
       # TODO(vsm): It's inconvenient that run_cmd isn't in scope here.
       # Perhaps there is a better place to put that or this.
-      subprocess.Popen(get_dartium, shell=has_shell)
+      subprocess.call(get_dartium, shell=has_shell)

[Emily Fortuna, 2012/04/25 18:38:58]

How about:
p = subprocess.Popen(cmd_list, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
hell=self.has_shell)	  
output, stderr = p.communicate(std_in);
if output:
  print output
if stderr:
  print stderr

We want the output from this call to not be swallowed in case there's an error.

     return browsers
 
 
 class CommonBrowserTest(RuntimePerformanceTest):
   """Runs this basic performance tests (Benchpress, some V8 benchmarks) in the
   browser."""
 
   def __init__(self, test_runner):
     """Args:
       test_runner: Reference to the object that notifies us when to run."""
@@ skipping 195 matching lines @@
               browser, version_name)
           self.test.trace_file = os.path.join(
               'tools', 'testing', 'perf_testing', self.test.result_folder_name,
               'dromaeo-%s-%s-%s' % (self.test.cur_time, browser, version_name))
           self.add_svn_revision_to_trace(self.test.trace_file, browser)
           file_path = '"%s"' % os.path.join(os.getcwd(), dromaeo_path,
               'index-js.html?%s' % version)
           self.test.test_runner.run_cmd(
               ['python', os.path.join('tools', 'testing', 'run_selenium.py'),
                '--out', file_path, '--browser', browser,
-               '--timeout', '600', '--mode', 'dromaeo'], self.test.trace_file,
+               '--timeout', '900', '--mode', 'dromaeo'], self.test.trace_file,
                append=True)
 
     @staticmethod
     def get_dromaeo_url_query(browser, version):
       if browser == 'dartium':
         version = version.replace('frog', 'dart')
       version = version.replace('_','&')
       tags = DromaeoTester.get_valid_dromaeo_tags()
       return '|'.join([ '%s&%s' % (version, tag) for tag in tags])
 
@@ skipping 290 matching lines @@
     while True:
       if runner.has_new_code():
         runner.run_test_sequence()
       else:
         time.sleep(200)
   else:
     runner.run_test_sequence()
 
 if __name__ == '__main__':
   main()