Issue 10191017: Get the absolute path of the test file when creating a tempory directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10191017: Get the absolute path of the test file when creating a tempory directory. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Get the absolute path of the test file when creating a tempory directory. Committed: https://code.google.com/p/dart/source/detail?r=6938

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	dart/tools/testing/dart/test_suite.dart	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. https://chromiumcodereview.appspot.com/10191017/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10191017/diff/1/dart/tools/testing/dart/test_suite.dart#newcode442 dart/tools/testing/dart/test_suite.dart:442: Directory tempDir = createOutputDirectory(testPath, ''); Sometimes we have ...

8 years, 8 months ago (2012-04-25 13:42:29 UTC) #2

ahe

8 years, 8 months ago (2012-04-25 13:47:55 UTC) #3

Thank you, Bill.

https://chromiumcodereview.appspot.com/10191017/diff/1/dart/tools/testing/dar...
File dart/tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10191017/diff/1/dart/tools/testing/dar...
dart/tools/testing/dart/test_suite.dart:442: Directory tempDir =
createOutputDirectory(testPath, '');
On 2012/04/25 13:42:29, Bill Hesse wrote:
> Sometimes we have had problems with a file path getting too long when we do
> this.  Make sure to check the Windows bots.

This is the same as is done in enqueBrowserTest below. So I assume it is safe.

Expand Messages | Collapse Messages