Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 10191017: Get the absolute path of the test file when creating a tempory directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index ce0891603ea0ee251c7f286b45f6b28aec5fc42e..c53921fa52af46316e3595e446007a1e21892f34 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -437,7 +437,8 @@ class StandardTestSuite implements TestSuite {
List<Command> makeCommands(TestInformation info, var args) {
if (configuration['compiler'] == 'dart2js') {
args = new List.from(args);
- String testPath = info.filename.replaceAll('\\', '/');
+ String testPath =
+ new File(info.filename).fullPathSync().replaceAll('\\', '/');
Directory tempDir = createOutputDirectory(testPath, '');
Bill Hesse 2012/04/25 13:42:29 Sometimes we have had problems with a file path ge
ahe 2012/04/25 13:47:56 This is the same as is done in enqueBrowserTest be
args.add('--out=${tempDir.path}/out.js');
List<Command> commands = <Command>[new Command(shellPath(), args)];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698