Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 10190005: Fix timeouts in standalone/io/TestRunnerTest by increasing timeout. Fix a few errors in test_runne… (Closed)

Created:
8 years, 8 months ago by Bill Hesse
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix timeouts in standalone/io/TestRunnerTest by increasing timeout. Fix a few errors in test_runner.dart. BUG= TEST=standalone/io/TestRunnerTest Committed: https://code.google.com/p/dart/source/detail?r=6881

Patch Set 1 #

Patch Set 2 : Fix builds with only x64 architecture. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M tests/standalone/src/io/ProcessTestUtil.dart View 1 2 chunks +10 lines, -2 lines 0 comments Download
M tests/standalone/src/io/TestRunnerTest.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
8 years, 8 months ago (2012-04-23 15:31:22 UTC) #1
Bill Hesse
Peter claims that he knows the problem, and it is a Windows popup on crashing ...
8 years, 8 months ago (2012-04-23 15:42:22 UTC) #2
Mads Ager (google)
On 2012/04/23 15:42:22, Bill Hesse wrote: > Peter claims that he knows the problem, and ...
8 years, 8 months ago (2012-04-24 06:32:34 UTC) #3
Søren Gjesse
8 years, 8 months ago (2012-04-24 14:09:59 UTC) #4
lgtm

Lets try it.

Powered by Google App Engine
This is Rietveld 408576698