Rework mirrors implementation.

Rework mirrors implementation.

(Note that the current mirrors implementation is just a heartbeat
implementation of a single method)

Use native code instead of dart code to do the work.

Use JSON instead of Lists/Maps for commands/responses.

Reenable disabled tests.
Committed: https://code.google.com/p/dart/source/detail?r=6864

[hausner, 2012-04-23 21:54:17]

lgtm

https://chromiumcodereview.appspot.com/10175011/diff/6001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10175011/diff/6001/runtime/lib/mirrors...
runtime/lib/mirrors.cc:111: if (!JSONGetLiteral(json_text, "ok", &ok, &ok_len)
||
If you don't throw away the JSONReader object after finding the "ok" value pair,
you could do something like:

if (r.Seek("ok") && r.IsLiteral("true")) { ...

Where IsLiteral is a trivial function that you can add to JSONReader.

[turnidge, 2012-04-23 22:14:19]

https://chromiumcodereview.appspot.com/10175011/diff/6001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10175011/diff/6001/runtime/lib/mirrors...
runtime/lib/mirrors.cc:111: if (!JSONGetLiteral(json_text, "ok", &ok, &ok_len)
||
On 2012/04/23 21:54:17, hausner wrote:
> If you don't throw away the JSONReader object after finding the "ok" value
pair,
> you could do something like:
> 
> if (r.Seek("ok") && r.IsLiteral("true")) { ...
> 
> Where IsLiteral is a trivial function that you can add to JSONReader.

Instead of IsLiteral I added IsTrue(), IsFalse(), and IsNull().