Issue 10170025: Use the correct current element when computing the type of function elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10170025: Use the correct current element when computing the type of function elements. (Closed)

Created:
8 years, 8 months ago by karlklose

Modified:
8 years, 8 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the correct current element when computing the type of function elements. R=ahe@google.com,kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=6841

Patch Set 2 : Add a test. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -17 lines)			Patch
	A	frog/tests/leg/src/CompilerTest.dart	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
	M	lib/compiler/implementation/elements/elements.dart	View	1	2 chunks	+21 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10170025/diff/1/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10170025/diff/1/lib/compiler/implementation/elements/elements.dart#newcode622 lib/compiler/implementation/elements/elements.dart:622: return compiler.withCurrentElement(this, () { Would it be possible ...

8 years, 8 months ago (2012-04-23 11:45:45 UTC) #2

LGTM!

Expand Messages | Collapse Messages

Issue 10170025: Use the correct current element when computing the type of function elements. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add a test. #

Messages