Use the correct current element when computing the type of function elements.

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
 #import('../leg.dart');  // TODO(karlklose): we only need type.
 #import('../util/util.dart');
@@ skipping 601 matching lines @@
   int optionalParameterCount(Compiler compiler) {
     return computeParameters(compiler).optionalParameterCount;
   }
 
   int parameterCount(Compiler compiler) {
     return computeParameters(compiler).parameterCount;
   }
 
   FunctionType computeType(Compiler compiler) {
     if (type != null) return type;
-    FunctionParameters parameters = computeParameters(compiler);
-    Types types = compiler.types;
-    FunctionExpression node =
-        compiler.parser.measure(() => parseNode(compiler));
-    Type returnType = getType(node.returnType, compiler, getLibrary());
-    if (returnType === null) returnType = types.dynamicType;
+    return compiler.withCurrentElement(this, () {

[kasperl, 2012/04/23 11:45:45]

Would it be possible to add a regression test case for this? How involved is it?

+      FunctionParameters parameters = computeParameters(compiler);
+      Types types = compiler.types;
+      FunctionExpression node =
+          compiler.parser.measure(() => parseNode(compiler));
+      Type returnType = getType(node.returnType, compiler, getLibrary());
+      if (returnType === null) returnType = types.dynamicType;
 
-    LinkBuilder<Type> parameterTypes = new LinkBuilder<Type>();
-    for (Link<Element> link = parameters.requiredParameters;
-         !link.isEmpty();
-         link = link.tail) {
-      parameterTypes.addLast(link.head.computeType(compiler));
-    }
-    type = new FunctionType(returnType, parameterTypes.toLink(), this);
-    return type;
+      LinkBuilder<Type> parameterTypes = new LinkBuilder<Type>();
+      for (Link<Element> link = parameters.requiredParameters;
+           !link.isEmpty();
+           link = link.tail) {
+        parameterTypes.addLast(link.head.computeType(compiler));
+      }
+      type = new FunctionType(returnType, parameterTypes.toLink(), this);
+      return type;
+    });
   }
 
   Node parseNode(DiagnosticListener listener) => cachedNode;
 
   Token position() => cachedNode.getBeginToken();
 }
 
 class ConstructorBodyElement extends FunctionElement {
   FunctionElement constructor;
 
@@ skipping 380 matching lines @@
   final Node node;
   Type bound;
   Type type;
   TypeVariableElement(name, Element enclosing, this.node, this.type,
                       [this.bound])
     : super(name, ElementKind.TYPE_VARIABLE, enclosing);
   Type computeType(compiler) => type;
   Node parseNode(compiler) => node;
   toString() => "${enclosingElement.toString()}.${name.slowToString()}";
 }