Remove frogsh.

Remove frogsh.

Committed: https://code.google.com/p/dart/source/detail?r=6840

[kasperl, 2012-04-20 12:53:09]

LGTM. I know this is a difficult change to make without potentially impacting
other people's work. I'm a little bit worried about the utils/apidoc/ changes.
It looks like some of the deleted files are overdue for a rewrite to dart:io.
Maybe you should reach out to one of the authors as part of landing this change?

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/frog.py
File dart/frog/frog.py (right):

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/frog.py#newc...
dart/frog/frog.py:40: if component == 'dartc':
Does this still exist (dartc_test)?

[sra1, 2012-04-20 18:05:18]

Please hold off on this change until we resolve the following.

minfrog is used to compile tests that live in the dartium / webkit tree.  Vijay
- do you think we could switch to a different version of the compiler for the
remaining Layout tests?

While this CL is removing frogsh as a variant of the compiler, it should not be
removed without adding self-host *test* to ensure that frog does not become too
broken to compile itself.  It is still the biggest and most sensitive test of
basic code-gen.

I also still have use for seeing changes to minfrog as a sanity check on
experiments I am doing on frog.
I have open CLs for the following:
- changes to the 'native' feature
- tree shaking native types
- analysis tool to help find bugs in dom/html
I rely on the self-host statistics printed by presubmit when working on these.

[Bob Nystrom, 2012-04-20 18:22:13]

This will break apidoc. It invokes minfrog in order to compile its client-side
Dart code to JS. See apidoc/apidoc.dart:63. You'll need to change that to invoke
some other Dart->JS compiler and ensure that the client-side code is still
working. To validate:

1. Do a (release) build. That will generate apidocs to
(out|xcodebuild)/Release_ia32/api_docs.
2. Spin up a web server out of that directory ("python -m SimpleHTTPServer"
works fine).
3. Hit that with a non-Dartium browser. Make sure navigation correctly shows up
on the left and that you can expand and collapse code in the content area.

Re: deleting stuff under apidoc, I'll add Nathan and Jacob to the review because
they wrote those scripts and know if they want them to stick around.

[sra1, 2012-04-21 17:10:27]

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/presubmit.py
File dart/frog/presubmit.py (left):

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/presubmit.py...
dart/frog/presubmit.py:152: 'isolate', 'peg', 'frog', 'css', 'frog_native']
If frogsh is not run on these tests then frog needs to be run instead.

[ahe, 2012-04-23 13:14:09]

Thank you for your comments.

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/frog.py
File dart/frog/frog.py (right):

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/frog.py#newc...
dart/frog/frog.py:40: if component == 'dartc':
On 2012/04/20 12:53:09, kasperl wrote:
> Does this still exist (dartc_test)?

Done.

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/presubmit.py
File dart/frog/presubmit.py (left):

https://chromiumcodereview.appspot.com/10164004/diff/1/dart/frog/presubmit.py...
dart/frog/presubmit.py:152: 'isolate', 'peg', 'frog', 'css', 'frog_native']
On 2012/04/21 17:10:27, sra1 wrote:
> If frogsh is not run on these tests then frog needs to be run instead.

Done.

[ahe, 2012-04-23 14:01:51]

On 2012/04/20 18:22:13, Bob Nystrom wrote:
> This will break apidoc. It invokes minfrog in order to compile its client-side
> Dart code to JS. See apidoc/apidoc.dart:63. You'll need to change that to
invoke
> some other Dart->JS compiler and ensure that the client-side code is still
> working. To validate:
> 
> 1. Do a (release) build. That will generate apidocs to
> (out|xcodebuild)/Release_ia32/api_docs.
> 2. Spin up a web server out of that directory ("python -m SimpleHTTPServer"
> works fine).
> 3. Hit that with a non-Dartium browser. Make sure navigation correctly shows
up
> on the left and that you can expand and collapse code in the content area.
> 
> Re: deleting stuff under apidoc, I'll add Nathan and Jacob to the review
because
> they wrote those scripts and know if they want them to stick around.

The build doesn't break although I removed minfrog. I'll fix it, this time.
Moving forward, please try to avoid silent build failures and write tests.