Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: dart/frog/presubmit.py

Issue 10164004: Remove frogsh. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/minfrog.dart ('k') | dart/frog/samples/ifrog.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/presubmit.py
diff --git a/dart/frog/presubmit.py b/dart/frog/presubmit.py
index 64b3383b175989cacec6b45676474d58ff999baf..438afbae6648ed0d32b23fddcad19d158f0b28a9 100755
--- a/dart/frog/presubmit.py
+++ b/dart/frog/presubmit.py
@@ -69,46 +69,6 @@ EXECUTABLE = (stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR |
stat.S_IRGRP | stat.S_IXGRP |
stat.S_IROTH | stat.S_IXOTH)
-def SelfHost():
- def b(s):
- """Adds ANSI escape-code for bold-face"""
- return "\033[1m%s\033[0m" % s
-
- # VM Checked/CompileAll, produces checked
- print 'Started'
- start = time.time()
- RunCommand('./frog/frog.py',
- '--vm_flags=--compile_all --enable_type_checks --enable_asserts',
- '--', '--compile_all', '--enable_type_checks',
- '--out=frog/minfrog', 'frog/minfrog.dart')
- elapsed = time.time() - start
- mode = 'in checked mode + compile all'
- print 'Compiling minfrog on Dart VM took %s seconds %s' % (
- b('%.1f' % elapsed), b(mode))
- os.chmod('./frog/minfrog', EXECUTABLE)
-
- # VM Production
- start = time.time()
- RunCommand('./frog/frog.py', '--', '--out=frog/minfrog', 'frog/minfrog.dart')
- elapsed = time.time() - start
- mode = 'in production mode'
- print 'Compiling minfrog on Dart VM took %s seconds %s' % (
- b('%.1f' % elapsed), b(mode))
- os.chmod('./frog/minfrog', EXECUTABLE)
-
- # Selfhost Production
- start = time.time()
- # TODO(jmesserly): --warnings_as_errors disabled until corelib is moved to
- # new factory syntax.
- RunCommand('./frog/minfrog', '--out=frog/minfrog', # '--warnings_as_errors',
- 'frog/minfrog.dart', 'frog/tests/hello.dart', verbose=True)
- elapsed = time.time() - start
- size = os.path.getsize('./frog/minfrog') / 1024
- print 'Bootstrapping minfrog took %s seconds %s' % (b('%.1f' % elapsed),
- b('in production mode'))
- print 'Generated %s minfrog is %s kB' % (b('production'), b(size))
-
-
def main():
dart_dir = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
os.chdir(dart_dir)
@@ -117,9 +77,6 @@ def main():
RunCommand('./tools/build.py', '--mode=release', 'dart2js')
- if not options.leg_only:
- SelfHost()
-
test_cmd = ['./tools/test.py', '--report', '--timeout=30',
'--progress=color', '--mode=release', '--checked']
@@ -129,7 +86,7 @@ def main():
if options.leg_only:
test_cmd.extend('--compiler=dart2js', '--runtime=d8')
else:
- test_cmd.append('--component=frogsh,dart2js')
+ test_cmd.extend('--compiler=frog,dart2js', '--runtime=d8')
test_cmd.extend(args)
RunCommand(*test_cmd, verbose=True)
else:
@@ -144,10 +101,8 @@ def main():
cmd = test_cmd + ['--compiler=frog', '--runtime=drt', 'client']
RunCommand(*cmd, verbose=True)
- # TODO(jimhug): Consider adding co19 back when it delivers more value
- # than pain.
- # Run frogsh on most of the tests.
- cmd = test_cmd + ['--compiler=frogsh', '--runtime=d8',
+ # Run frog on most of the tests.
+ cmd = test_cmd + ['--compiler=frog', '--runtime=d8',
'language', 'corelib',
'isolate', 'peg', 'frog', 'css', 'frog_native']
RunCommand(*cmd, verbose=True)
« no previous file with comments | « dart/frog/minfrog.dart ('k') | dart/frog/samples/ifrog.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698