Unregister callbacks from socket, when we return the socket for reuse.

Unregister callbacks from socket, when we return the socket for reuse.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6869

[Søren Gjesse, 2012-04-20 11:07:22]

This should already be the case.

https://chromiumcodereview.appspot.com/10164001/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10164001/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:1114: _socket.onData = null;
_returnSocketConnection already does this (calls _markReturned as its last
action).

[Anders Johnsen, 2012-04-20 11:13:42]

https://chromiumcodereview.appspot.com/10164001/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10164001/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:1114: _socket.onData = null;
On 2012/04/20 11:07:22, Søren Gjesse wrote:
> _returnSocketConnection already does this (calls _markReturned as its last
> action).

It's done iff shutdown is not marked. Is there a odd chance that socket will
send out onData/onClosed after a close() call?

[Søren Gjesse, 2012-04-20 11:27:35]

https://chromiumcodereview.appspot.com/10164001/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10164001/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:1114: _socket.onData = null;
On 2012/04/20 11:13:42, ajohnsen wrote:
> On 2012/04/20 11:07:22, Søren Gjesse wrote:
> > _returnSocketConnection already does this (calls _markReturned as its last
> > action).
> 
> It's done iff shutdown is not marked. Is there a odd chance that socket will
> send out onData/onClosed after a close() call?

How about just moving the _markReturned to the top of _returnSocketConnection?

[Anders Johnsen, 2012-04-20 11:29:29]

Will do!

[Anders Johnsen, 2012-04-23 12:41:58]

Like so?

[Søren Gjesse, 2012-04-23 15:14:24]

lgtm

Yes!