Issue 10117031: Move 'revision' file creation from upload_sdk into create_sdk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10117031: Move 'revision' file creation from upload_sdk into create_sdk (Closed)

Created:
8 years, 8 months ago by danrubel

Modified:
8 years, 8 months ago

Reviewers:
dgrove, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move 'revision' file creation from upload_sdk into create_sdk Committed: https://code.google.com/p/dart/source/detail?r=6712

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
M	tools/create_sdk.py	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/upload_sdk.py	View	1 2	2 chunks	+1 line, -12 lines	0 comments	Download
M	tools/utils.py	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgrove

https://chromiumcodereview.appspot.com/10117031/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10117031/diff/1/tools/create_sdk.py#newcode432 tools/create_sdk.py:432: return 1 how does this work for git users? ...

8 years, 8 months ago (2012-04-18 20:53:05 UTC) #2

danrubel

8 years, 8 months ago (2012-04-18 21:31:39 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 10117031: Move 'revision' file creation from upload_sdk into create_sdk (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages