Issue 10116023: Don't rely on any speculative type in the bailout version.

Issue 10116023: Don't rely on any speculative type in the bailout version. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't rely on any speculative type in the bailout version. Committed: https://code.google.com/p/dart/source/detail?r=6702

Patch Set 2 : Cosmetic change (formatting). #

Total comments: 8

Patch Set 3 : Address comments. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -26 lines)			Patch
M	lib/compiler/implementation/ssa/bailout.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1 2	6 chunks	+23 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1 2	2 chunks	+12 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/types.dart	View	1 2	4 chunks	+11 lines, -7 lines	0 comments	Download
M	tests/language/language-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implementation/ssa/nodes.dart#newcode1083 lib/compiler/implementation/ssa/nodes.dart:1083: if (isActive) return guardedType; return isActive ? guardedType ...

8 years, 8 months ago (2012-04-18 11:46:15 UTC) #2

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implementation/ssa/nodes.dart#newcode1072 lib/compiler/implementation/ssa/nodes.dart:1072: bool isActive = false; Not sure, but for ...

8 years, 8 months ago (2012-04-18 12:05:09 UTC) #3

floitsch

8 years, 8 months ago (2012-04-18 17:18:46 UTC) #4

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:1072: bool isActive = false;
On 2012/04/18 12:05:09, ngeoffray wrote:
> Not sure, but for me isOn conveys more what this is doing.

Done.

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:1083: if (isActive) return
guardedType;
On 2012/04/18 11:46:15, kasperl wrote:
> return isActive ? guardedType : guarded.propagatedType;

Done.

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/optimize.dart:50: // propagated types
non-speculatively. For example, it propagated the
On 2012/04/18 11:46:15, kasperl wrote:
> it propagated -> it might have propagated

Done.

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/types.dart (right):

https://chromiumcodereview.appspot.com/10116023/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/types.dart:123: if
(instruction.propagatedType.isConflicting()) {
On 2012/04/18 11:46:15, kasperl wrote:
> Cache instruction.propagatedType in a local variable?

Done.

Expand Messages | Collapse Messages